Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3474 Remove duplicate accessions when fetching from db #81

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

nitin-ebi
Copy link
Contributor

No description provided.

@nitin-ebi nitin-ebi self-assigned this Jan 12, 2024
@@ -82,14 +82,19 @@ public void testRecoverState() {

assertEquals(3, contiguousIdBlockService.getUncompletedBlocksByCategoryIdAndApplicationInstanceIdOrderByEndAsc(categoryId, instanceId2).size());

// create and save accessions in db (100 to 124)
List<AccessionWrapper<TestModel, String, Long>> accessions = LongStream.range(100l, 125l)
// create and save accessions in db (100 to 124) - save 2 tests of same accessions with different hashes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// create and save accessions in db (100 to 124) - save 2 tests of same accessions with different hashes
// create and save accessions in db (100 to 124) - save 2 sets of same accessions with different hashes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@nitin-ebi nitin-ebi merged commit 9966bc2 into EBIvariation:master Jan 12, 2024
1 check passed
@nitin-ebi nitin-ebi deleted the recover-state branch March 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants