Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3505 Update MD5-checksum-update - using pagination #126

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

nitin-ebi
Copy link
Contributor

No description provided.

@nitin-ebi nitin-ebi self-assigned this Feb 13, 2024
@nitin-ebi
Copy link
Contributor Author

nitin-ebi commented Feb 14, 2024

While testing with pagination, I noticed the pagination logic does not work correctly if you don't provide sorting logic through page object or query. It tends to bring rows already fetched in previous pages and also causes the pagination to miss fetching some data that it should have fetched.
As part of this PR, I also updated all our repository queries that fetch pages of chromosomes to be sorted by insdc_accession.

I also tried to test these changes with only querying chromosomes where md5checksum is null, but querying with the condition and modifying the chromosomes at the same time, messes with count and pagination logic, so we will have to go through the entire set of chromosomes in the assembly.

@nitin-ebi nitin-ebi changed the title EVA-3505 Update MD5-checksum-update logic - download file and read INSDC accession from it EVA-3505 Update MD5-checksum-update - using pagination Feb 14, 2024
@nitin-ebi nitin-ebi merged commit 3cba50f into EBIvariation:master Feb 19, 2024
1 check passed
@nitin-ebi nitin-ebi deleted the update-md5 branch February 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants