Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: April Shen <april.tuesday@gmail.com>
  • Loading branch information
tcezard and apriltuesday authored Jan 31, 2024
1 parent 2e104fe commit 511fbbf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ EVA Submission Command Line Interface for Validation
## Installation


## input file for the validation and submission tool
## Input files for the validation and submission tool

### The VCF file and association with reference genome

The path to the VCF files are provided via CSV file that links the VCF to their respective fasta sequence. This allows
us to support different assemblies for each VCF file
The CSV file `vcf_mapping.csv` contains the following columns vcf, fasta, report providing respectively:
- The VCF to validatio/upload
- The VCF to validate/upload
- The assembly in fasta format that was used to derive the VCF
- The assembly report associated with the assembly (if available) as found in NCBI assemblies (https://www.ncbi.nlm.nih.gov/genome/doc/ftpfaq/#files)

Expand All @@ -34,7 +34,7 @@ It should be populated following the instruction provided within the template

## Execution

### Validate and submit you dataset
### Validate and submit your dataset

To validate and submit run the following command

Expand Down
6 changes: 3 additions & 3 deletions bin/eva-sub-cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
if __name__ == "__main__":
argparser = ArgumentParser(description='EVA Submission CLI - validate and submit data to EVA')
argparser.add_argument('--tasks', nargs='*', choices=[VALIDATE, SUBMIT], default=[SUBMIT],
help='Select a task to perform. Stating VALIDATE run the validation regardless of the '
'previous runs, Stating SUBMIT run validate only if the validation was not performed '
'successfully before and run the submission.')
help='Select a task to perform. Selecting VALIDATE will run the validation regardless of the outcome of '
'previous runs. Selecting SUBMIT will run validate only if the validation was not performed '
'successfully before and then run the submission.')
argparser.add_argument('--submission_dir', required=True, type=str,
help='Full path to the directory where all processing will be done '
'and submission info is/will be stored')
Expand Down

0 comments on commit 511fbbf

Please sign in to comment.