Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: nitin-ebi <79518737+nitin-ebi@users.noreply.github.com>
Co-authored-by: April Shen <april.tuesday@gmail.com>
  • Loading branch information
3 people authored Feb 14, 2024
1 parent bf3ad5b commit d5296c0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ There are two ways of specifying the VCF files and associated assembly

### Using `--vcf_files` and `--assembly_fasta`

This allows you to provide multiple VCF file to validate and a single genome file associated.
The VCF file and genome associated must use the same chromosome naming convention
This allows you to provide multiple VCF files to validate and a single associated genome file.
The VCF files and the associated genome file must use the same chromosome naming convention

### Using `--vcf_files_mapping`

Expand Down
10 changes: 5 additions & 5 deletions bin/eva-sub-cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def validate_command_line_arguments(args, argparser):
sys.exit(1)

if (args.vcf_files and not args.assembly_fasta) or (not args.vcf_files and args.assembly_fasta):
print("When using --vcf_files and --assembly_fasta, both needs to be specified")
print("When using --vcf_files and --assembly_fasta, both need to be specified")
argparser.print_usage()
sys.exit(1)

Expand All @@ -35,16 +35,16 @@ def validate_command_line_arguments(args, argparser):
'and submission info is/will be stored')
vcf_group = argparser.add_argument_group(
'Input VCF and assembly',
"Specify the VCF files and associated assembly with the following options. If you used different assembly "
"Specify the VCF files and associated assembly with the following options. If you used different assemblies "
"for different VCF files then use --vcf_file_mapping"
)
vcf_group.add_argument('--vcf_files', nargs='+', help="One or several vcf file to validate")
vcf_group.add_argument('--vcf_files', nargs='+', help="One or several vcf files to validate")
vcf_group.add_argument('--assembly_fasta',
help="The fasta file containing the reference genome from which the variant were derived")
help="The fasta file containing the reference genome from which the variants were derived")
vcf_group.add_argument("--vcf_files_mapping",
help="csv file with the mappings for vcf files, fasta and assembly report")

metadata_group = argparser.add_argument_group('Metadata', 'Specify the metadata in a spreadsheet of in a JSON file')
metadata_group = argparser.add_argument_group('Metadata', 'Specify the metadata in a spreadsheet or in a JSON file')
metadata_group = metadata_group.add_mutually_exclusive_group(required=True)
metadata_group.add_argument("--metadata_json",
help="Json file that describe the project, analysis, samples and files")
Expand Down

0 comments on commit d5296c0

Please sign in to comment.