Skip to content

Commit

Permalink
update verify_ready_for_submission_to_eva to check if shallow validat…
Browse files Browse the repository at this point in the history
…ion was performed
  • Loading branch information
nitin-ebi committed Nov 15, 2024
1 parent bbf2173 commit e7c8f0a
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion eva_sub_cli/validators/validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,14 @@ def update_config_with_validation_result(self):

def verify_ready_for_submission_to_eva(self):
""" Checks if all the validation are passed """
return all((value.get('PASS', False) is True for key, value in self.results.items()))
return all((
all((value.get('PASS', False) is True for key, value in self.results.items() if
key in ['vcf_check', 'assembly_check', 'fasta_check', 'sample_check', 'metadata_check'])),
any((
self.results['shallow_validation']['requested'] is False,
self.results['shallow_validation'].get('required', True) is False
))
))

def _collect_validation_workflow_results(self):
# Collect information from the output and summarise in the config
Expand Down

0 comments on commit e7c8f0a

Please sign in to comment.