-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVA-3439 - Conda build #21
Conversation
|
||
extra: | ||
recipe-maintainers: | ||
- apriltuesday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to add other maintainers, AFAICT the main effect is that you get tagged when the conda version is bumped (and I guess are also responsible if the build breaks!)
version: {{ version }} | ||
|
||
source: | ||
path: ../ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change this before we merge, but meanwhile this should allow you to test locally, e.g.
conda activate <env>
cd eva-sub-cli/conda # directory containing the recipe
conda build .
conda install --use-local eva-sub-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this a bit, for now we'll leave it as is to enable local building.
Note that to get the above commands to work, you also need to either have the correct channels in your config (running conda config --add channels bioconda conda-forge
), or specify the channels explicitly in both build
and install
commands (adding -c bioconda -c conda-forge
to both).
The command in the readme right now should work fine once it's actually on conda.
# Includes some workarounds that can be cleaned up once a new version is released | ||
curl -Lo biovalidator.zip https://github.com/elixir-europe/biovalidator/archive/refs/tags/v${BIOVALIDATOR_VERSION}.zip \ | ||
&& unzip biovalidator.zip && rm biovalidator.zip \ | ||
&& cd biovalidator-${BIOVALIDATOR_VERSION} \ | ||
&& bash -c "cat <(echo '#!/usr/bin/env node') <(cat src/biovalidator.js) > tmp" \ | ||
&& mv tmp src/biovalidator.js \ | ||
&& chmod +x src/biovalidator.js \ | ||
&& sed -i 's/dist/src/' package.json \ | ||
&& npm install && npm install -g \ | ||
&& cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They said they'll tag a new version soon.
There are currently three ways to install and run the tool: using conda, from source using Docker, | ||
and from source natively (i.e. managing dependencies on your own). | ||
|
||
### Conda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit presumptive as it hasn't been submitted to the channel yet, I'm assuming it will be fine 🤞
Based on #23, see diff here