Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVA-3666 - Docker resilience #62

Merged
merged 7 commits into from
Sep 24, 2024
Merged

EVA-3666 - Docker resilience #62

merged 7 commits into from
Sep 24, 2024

Conversation

tcezard
Copy link
Member

@tcezard tcezard commented Sep 19, 2024

  • Ensure that docker stops at the end of the process
  • Ensure that two concurrent runs use a different docker process
  • Retry downloading the image if it fails the first time
  • Lock the submission directory at the start of the process to prevent multiple execution on the same directory

apriltuesday
apriltuesday reviewed Sep 20, 2024
View reviewed changes
eva_sub_cli/executables/cli.py Outdated Show resolved Hide resolved
eva_sub_cli/validators/docker_validator.py Outdated Show resolved Hide resolved
eva_sub_cli/validators/docker_validator.py Show resolved Hide resolved
eva_sub_cli/validators/docker_validator.py Show resolved Hide resolved
tests/test_docker_validator.py Outdated Show resolved Hide resolved
tests/test_docker_validator.py Outdated Show resolved Hide resolved
@tcezard tcezard merged commit 5c60afb into EBIvariation:main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitin-ebi nitin-ebi nitin-ebi approved these changes

@apriltuesday apriltuesday apriltuesday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcezard @apriltuesday @nitin-ebi