Prevent upload of metadata if it already exists

EBIvariation · Oct 2, 2024 · 41f5c98 · 41f5c98
1 parent 5c99a98
commit 41f5c98
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/main/java/uk/ac/ebi/eva/submission/controller/submissionws/SubmissionController.java b/src/main/java/uk/ac/ebi/eva/submission/controller/submissionws/SubmissionController.java
@@ -93,6 +93,15 @@ public ResponseEntity<?> markSubmissionUploaded(@RequestHeader("Authorization")
             return new ResponseEntity<>("Unauthorized", HttpStatus.UNAUTHORIZED);
         }
 
+        submissionService.checkMetadataFileInfoMatchesWithUploadedFiles(submissionAccount, submissionId, metadataJson);
+        String submissionStatus = submissionService.getSubmissionStatus(submissionId);
+        if (! Objects.equals(submissionStatus, SubmissionStatus.OPEN.toString())){
+            return new ResponseEntity<>(
+                    "Submission " + submissionId + "is not in status " + SubmissionStatus.OPEN +
+                            " so cannot be marked as " + SubmissionStatus.UPLOADED +
+                            "Current Status: " + submissionStatus,
+                    HttpStatus.BAD_REQUEST);
+        }
         try {
             submissionService.checkMetadataFileInfoMatchesWithUploadedFiles(submissionAccount, submissionId, metadataJson);
             Submission submission = this.submissionService.uploadMetadataJsonAndMarkUploaded(submissionId, metadataJson);