Apply suggestions from code review

Co-authored-by: April Shen <april.tuesday@gmail.com>
EBIvariation · Oct 3, 2024 · 6a8fd5d · 6a8fd5d
1 parent 6db78ce
commit 6a8fd5d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/main/java/uk/ac/ebi/eva/submission/controller/submissionws/SubmissionController.java b/src/main/java/uk/ac/ebi/eva/submission/controller/submissionws/SubmissionController.java
@@ -94,10 +94,9 @@ public ResponseEntity<?> markSubmissionUploaded(@RequestHeader("Authorization")
         }
 
         String submissionStatus = submissionService.getSubmissionStatus(submissionId);
-        System.out.println(submissionStatus);
         if (! Objects.equals(submissionStatus, SubmissionStatus.OPEN.toString())){
             return new ResponseEntity<>(
-                    "Submission " + submissionId + "is not in status " + SubmissionStatus.OPEN +
+                    "Submission " + submissionId + " is not in status " + SubmissionStatus.OPEN +
                             ". It cannot be marked as " + SubmissionStatus.UPLOADED +
                             ". Current Status: " + submissionStatus,
                     HttpStatus.BAD_REQUEST);

diff --git a/src/test/java/uk/ac/ebi/eva/submission/integration/SubmissionWSIntegrationTest.java b/src/test/java/uk/ac/ebi/eva/submission/integration/SubmissionWSIntegrationTest.java
@@ -633,7 +633,7 @@ public void testSubmissionAlreadyUploaded() throws Exception {
                         .content(metadataJson)
                         .contentType(MediaType.APPLICATION_JSON))
                 .andExpect(status().isBadRequest())
-                .andExpect(content().string("Submission " + submissionId + "is not in status OPEN. " +
+                .andExpect(content().string("Submission " + submissionId + " is not in status OPEN. " +
                         "It cannot be marked as UPLOADED. Current Status: UPLOADED"));
     }