EVA-3696 - Retrieve Submission details endpoint #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/uk/ac/ebi/eva/submission/service/SubmissionService.java
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
66
| @Operation(summary = "This endpoint retrieves all the submissions from the database with given step and status") | ||
| @Parameters({ | ||
| @Parameter(name="step", description = "The processing step of the submission.", | ||
| required = true, in= ParameterIn.PATH), | ||
| @Parameter(name="status", description = "The status of the submission processing step.", | ||
| required = true, in= ParameterIn.PATH) | ||
| }) |
There was a problem hiding this comment.
Think this is the wrong summary & parameters...
src/main/java/uk/ac/ebi/eva/submission/controller/admin/AdminController.java
Outdated
Show resolved
Hide resolved
src/test/java/uk/ac/ebi/eva/submission/integration/SubmissionWSIntegrationTest.java
Outdated
Show resolved
Hide resolved
| public ResponseEntity<?> getSubmissionsDetail( | ||
| @PathVariable("submissionId") String submissionId) { | ||
| SubmissionDetails submissionDetail = submissionService.getSubmissionDetail(submissionId); | ||
| return new ResponseEntity<>(submissionDetail, HttpStatus.OK); |
There was a problem hiding this comment.
Should this also handle SubmissionDoesNotExistException like the other endpoints?
Co-authored-by: April Shen <april.tuesday@gmail.com>
apriltuesday
approved these changes
Dec 17, 2024
| @Parameter(name="step", description = "The processing step of the submission.", | ||
| required = true, in= ParameterIn.PATH), | ||
| @Parameter(name="status", description = "The status of the submission processing step.", | ||
| @Parameter(name="submissionId", description = "Id of the submission whose status needs to be updated", |
There was a problem hiding this comment.
Suggested change
| @Parameter(name="submissionId", description = "Id of the submission whose status needs to be updated", | |
| @Parameter(name="submissionId", description = "Id of the submission to fetch", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.