Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVA-3491: Add schema for submission tables #8

Merged
merged 6 commits into from
Feb 9, 2024
Merged

EVA-3491: Add schema for submission tables #8

merged 6 commits into from
Feb 9, 2024

Conversation

apriltuesday
Copy link
Contributor

Also added the Gitlab deployment since I think it makes sense at this point, we can discuss...

@apriltuesday apriltuesday self-assigned this Feb 7, 2024
nitin-ebi
nitin-ebi requested changes Feb 8, 2024
View reviewed changes
src/test/resources/init.sql Outdated Show resolved Hide resolved
@nitin-ebi
Copy link
Collaborator

nitin-ebi commented Feb 8, 2024 •
edited
Loading

Looks Good.
Could you also add this as a default schema, I guess it is possible to define it in spring-properties, something like this:
spring.jpa.properties.hibernate.default_schema=eva_submissions (have not tested this though)
Just as a protective measure, there is always a chance of messing up or forgetting when creating new tables or writing new queries

apriltuesday and others added 2 commits February 9, 2024 13:00
@apriltuesday @nitin-ebi
Update src/test/resources/init.sql
095c7a1 
Co-authored-by: nitin-ebi <79518737+nitin-ebi@users.noreply.github.com>
@apriltuesday
add default schema to properties
cd11a3a
@apriltuesday
Copy link
Contributor Author

@nitin-ebi Good point, added

@apriltuesday apriltuesday merged commit 8b70144 into EBIvariation:main Feb 9, 2024
1 check passed
@apriltuesday apriltuesday deleted the EVA-3491 branch February 9, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitin-ebi nitin-ebi nitin-ebi approved these changes

@tcezard tcezard tcezard approved these changes

Assignees

@apriltuesday apriltuesday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apriltuesday @nitin-ebi @tcezard