Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run the annotation and the stats for analysis or the whole study #196

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

tcezard
Copy link
Member

@tcezard tcezard commented Jan 24, 2024

No description provided.

@@ -410,9 +416,8 @@ process calculate_statistics_vcf {
pipeline_parameters += " --spring.batch.job.names=calculate-statistics-job"

pipeline_parameters += " --input.vcf.aggregation=" + aggregation.toString().toUpperCase()
pipeline_parameters += " --input.vcf=" + vcf_file.toRealPath().toString()
pipeline_parameters += " --input.vcf=" + file(vcf_files[0]).toRealPath().toString() // If there are multiple file only use the first
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite clear on the consequence of this choice yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the code is using the file ID rather than the filename, so this is probably okay... I'm actually wondering, since the file ID is the analysis accession, whether we've been computing the same stats multiple times for the same analysis if it contains multiple files...

@@ -410,9 +416,8 @@ process calculate_statistics_vcf {
pipeline_parameters += " --spring.batch.job.names=calculate-statistics-job"

pipeline_parameters += " --input.vcf.aggregation=" + aggregation.toString().toUpperCase()
pipeline_parameters += " --input.vcf=" + vcf_file.toRealPath().toString()
pipeline_parameters += " --input.vcf=" + file(vcf_files[0]).toRealPath().toString() // If there are multiple file only use the first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the code is using the file ID rather than the filename, so this is probably okay... I'm actually wondering, since the file ID is the analysis accession, whether we've been computing the same stats multiple times for the same analysis if it contains multiple files...

@tcezard tcezard merged commit b4511a2 into EBIvariation:master Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants