-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVA-3330: Add labels to nextflow for SLURM migration #40
Conversation
maxRetries 3 | ||
// Memory required is 10 times the size of the fasta in Bytes or at least 2GB | ||
// Overwrite base_memory so that the standard retry strategy is used | ||
ext base_memory: { Math.max(file(params.newgenome).size() * 10, 2000000000) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now working with updated configs, see run on Seqera
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but I'm wondering how anyone else that does not have our nextflow config would use this.
We could add some default nextflow config to the repo or add to the documentation how the memory requirement should be managed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is a good point, a config placed alongside the pipelines would (I think) take precedence over the one in the home directory which I'm not sure is a good idea for us. But including an example config somewhere and documenting the usage is definitely a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, here
maxRetries 3 | ||
// Memory required is 10 times the size of the fasta in Bytes or at least 2GB | ||
// Overwrite base_memory so that the standard retry strategy is used | ||
ext base_memory: { Math.max(file(params.newgenome).size() * 10, 2000000000) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but I'm wondering how anyone else that does not have our nextflow config would use this.
We could add some default nextflow config to the repo or add to the documentation how the memory requirement should be managed.
Looks good to me |
No description provided.