review comments incorporated

EBIvariation · Oct 23, 2023 · 65c790a · 65c790a
1 parent 723b382
commit 65c790a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...mons-core/src/main/java/uk/ac/ebi/eva/commons/core/models/AbstractVariantSourceEntry.java b/...mons-core/src/main/java/uk/ac/ebi/eva/commons/core/models/AbstractVariantSourceEntry.java
@@ -66,10 +66,7 @@ public AbstractVariantSourceEntry(String fileId, String studyId, String[] second
         this.fileId = fileId;
         this.studyId = studyId;
         if (secondaryAlternates != null) {
-            this.secondaryAlternates = Arrays.stream(secondaryAlternates)
-                    .map(a->a.toUpperCase())
-                    .collect(Collectors.toList())
-                    .toArray(new String[0]);
+            setSecondaryAlternates(secondaryAlternates);
         } else {
             this.secondaryAlternates = new String[]{};
         }

diff --git a/...ion-commons-mongodb/src/main/java/uk/ac/ebi/eva/commons/mongodb/filter/FilterBuilder.java b/...ion-commons-mongodb/src/main/java/uk/ac/ebi/eva/commons/mongodb/filter/FilterBuilder.java
@@ -115,8 +115,8 @@ public FilterBuilder withVariantTypes(VariantType variantType) {
 
     public FilterBuilder withAlternates(List<String> alternates) {
         if (alternates != null && !alternates.isEmpty()) {
-            alternates = alternates.stream().map(a->a.toUpperCase()).collect(Collectors.toList());
-            filters.add(new VariantRepositoryAlternateFilter(alternates));
+            List<String> alternatesUppercase = alternates.stream().map(a->a.toUpperCase()).collect(Collectors.toList());
+            filters.add(new VariantRepositoryAlternateFilter(alternatesUppercase));
         }
         return this;
     }