Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ragel output with -G2 and warning updates #258

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

vasudeva8
Copy link
Collaborator

Ragel output was earlier with -G0 and now updated with -G2 as mentioned in documentation.
A few warnings found in linux are fixed as well.

@vasudeva8 vasudeva8 requested a review from tcezard September 20, 2024 16:20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 month ago we updated the other 3 ragel files.
We might need to regenerate.

Copy link
Collaborator Author

@vasudeva8 vasudeva8 Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like they were regenerated at that time using correct level, -G2, itself (on #248).

During the check it came to notice that an earlier PR (#246) had a vcf.ragel update which necessitates regeneration of all the 3, for a message update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all ragel dependent headers.

@nyyubio
Copy link

nyyubio commented Sep 23, 2024 via email

@vasudeva8 vasudeva8 merged commit d1b0720 into EBIvariation:dev/vcf4.4 Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants