Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix Clang UB sanitizer, disable Clang thread sanitizer #5474

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Nov 20, 2024

I started seeing this error from the Clang sanitizer workflow in several PRs:

E: The repository 'http://archive.ubuntu.com/ubuntu mantic Release' does not have a Release file.
E: The repository 'http://archive.ubuntu.com/ubuntu mantic-updates Release' does not have a Release file.
E: The repository 'http://archive.ubuntu.com/ubuntu mantic-backports Release' does not have a Release file.
E: The repository 'http://security.ubuntu.com/ubuntu mantic-security Release' does not have a Release file.

The Ubuntu 23.10 container was introduced in #5181 when ubuntu-24.04 was pre-release as GitHub-hosted runner.

I think we can try to move to ubuntu-24.04 now and see if this is enough to fix the issue above.

@EZoni EZoni added the component: tests Tests and CI label Nov 20, 2024
@EZoni EZoni requested a review from lucafedeli88 November 20, 2024 00:29
@EZoni EZoni added the bug Something isn't working label Nov 20, 2024
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch 3 times, most recently from c1d3f80 to 2d2193d Compare November 20, 2024 00:35
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch from 2d2193d to 27b5205 Compare November 20, 2024 00:36
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch 3 times, most recently from e76dfcd to fb1106c Compare November 20, 2024 19:10
@EZoni
Copy link
Member Author

EZoni commented Nov 20, 2024

Currently debugging this new error, any suggestions?

/usr/bin/llvm-symbolizer-17: error: '[stack]': No such file or directory

@EZoni EZoni requested a review from WeiqunZhang November 21, 2024 01:10
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch from 7e1e967 to b8d25b3 Compare November 22, 2024 22:48
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch from c6b422e to ad6a975 Compare December 2, 2024 23:11
@RemiLehe RemiLehe changed the title CI: fix Ubuntu version for Clang sanitizer workflow [WIP] CI: fix Ubuntu version for Clang sanitizer workflow Dec 3, 2024
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch from ad6a975 to be0f8eb Compare December 3, 2024 00:13
@EZoni EZoni changed the title [WIP] CI: fix Ubuntu version for Clang sanitizer workflow [WIP] CI: fix Clang UB sanitizer, disable Clang thread sanitizer Dec 3, 2024
@EZoni EZoni changed the title [WIP] CI: fix Clang UB sanitizer, disable Clang thread sanitizer CI: fix Clang UB sanitizer, disable Clang thread sanitizer Dec 3, 2024
@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch 3 times, most recently from ed9ea44 to 836cf73 Compare December 3, 2024 00:19
@EZoni
Copy link
Member Author

EZoni commented Dec 3, 2024

Currently debugging this new error, any suggestions?

/usr/bin/llvm-symbolizer-17: error: '[stack]': No such file or directory

Will temporarily disable tests that raise data race conditions until we find a fix.

@EZoni EZoni force-pushed the ci_fix_clang_sanitizer branch from 836cf73 to db69251 Compare December 3, 2024 05:01
@EZoni
Copy link
Member Author

EZoni commented Dec 3, 2024

@RemiLehe

I disabled the Clang thread sanitizer job directly in this PR. The remaining Ubuntu version updates that you see in this PR are needed to fix the original issue that the PR meant to address (occurring for both the UB sanitizer job and the thread sanitizer job).

I will open a new PR re-enabling the thread sanitizer job in order to allow for more debugging, once this PR is merged.

@EZoni EZoni requested a review from RemiLehe December 3, 2024 16:53
@RemiLehe RemiLehe merged commit 780a584 into ECP-WarpX:development Dec 3, 2024
37 checks passed
@EZoni EZoni deleted the ci_fix_clang_sanitizer branch December 3, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants