Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tei stylesheets #371

Merged
merged 45 commits into from
Apr 15, 2024
Merged

Update tei stylesheets #371

merged 45 commits into from
Apr 15, 2024

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Apr 8, 2024

  • This PR adds the TEI Stylesheets as git-submodule and updates them to 7.56.0
  • moreover, it
    • add a new directory add/data/xslt/tei where the TEI Stylesheets live in the Stylesheets folder
    • moves the corresponding XSLTs for transforming TEI body and TEI header to HTML to new locations add/data/xslt/tei/profiles/ edirom-body and edirom-header respectively
    • reworks the body and header XSLTs (as far as test data and setup permitted) to work with the new version of the TEI Stylesheets

before there were some parameter values that were enclosed in ticks this lead to those parameter being of wrong value for evaluation through the Stylesheets
the disambiguation or injection possibility of in-file stylesheet instructions has already been handled in the declaration of the $xsl variable; consequently no if-else clause is needed to execute the transformation
this is good for local testing outside of the database
* tei:is-inline has been renamed to tei:isInline
* tei:blockContext does not exist anymore but rules were moved to tei:isInline
* do not copy from TEI Stylesheets instead use xsl:choose statement with xsl:next-match as fallback
@bwbohl bwbohl added this to the 1.0.0-beta.6 milestone Apr 8, 2024
@bwbohl bwbohl requested review from riedde and roewenstrunk and removed request for riedde April 11, 2024 13:30
Copy link
Contributor

@riedde riedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That was very necessary!

@bwbohl bwbohl merged commit f613eb7 into develop Apr 15, 2024
1 check passed
@bwbohl bwbohl deleted the cleanup/update-tei-stylesheets branch April 15, 2024 04:54
@bwbohl bwbohl mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants