MR-3578 Fix Date Added document date bug #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor how fetchHealthPlanPackageWrapper deals internally with data. - pass along revisionsLookup instead of a form data look up - adjust makeDocumentKeyLookup and makeDocumentDateLookup - use JS set to simplify document list usage
…g is taking too long for new code
haworku
changed the title
haworku
requested review from
rswerve,
JasonLin0991 and
macrael
and removed request for
rswerve
rswerve
reviewed
Jul 21, 2023
| const previousSubmissionDate = | ||
| documentDateLookupTable.previousSubmissionDate | ||
|
|
||
| if (!documentDate || !previousSubmissionDate) { |
There was a problem hiding this comment.
I love a good series of if statements
rswerve
reviewed
Jul 21, 2023
| console.error( | ||
| `makeDocumentS3KeyLookup- Failed to read S3 key for $${doc.name} - ${doc.s3URL}` | ||
| ) | ||
| // fail silently, just return good documents |
There was a problem hiding this comment.
really like the comments in this PR
rswerve
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the
submitInfo.updatedAtinstead of the protoupdatedAtto determine the date added for documents.Related issues
https://qmacbis.atlassian.net/browse/MR-3578
Screenshots
Test cases covered
UploadedDocumentsTablehas some new tests to reflect the new behavior on review and submit with new submissions (don't show any date/empty string)QA guidance
I ended up separating off the refactor so this change is pretty contained to uploaded documents behavior i would test that across submissions