-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MR-3578 Fix Date Added document date bug #1827
Conversation
- refactor how fetchHealthPlanPackageWrapper deals internally with data. - pass along revisionsLookup instead of a form data look up - adjust makeDocumentKeyLookup and makeDocumentDateLookup - use JS set to simplify document list usage
…g is taking too long for new code
const previousSubmissionDate = | ||
documentDateLookupTable.previousSubmissionDate | ||
|
||
if (!documentDate || !previousSubmissionDate) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love a good series of if statements
console.error( | ||
`makeDocumentS3KeyLookup- Failed to read S3 key for $${doc.name} - ${doc.s3URL}` | ||
) | ||
// fail silently, just return good documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really like the comments in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. much clearer and more robust
Summary
Use the
submitInfo.updatedAt
instead of the protoupdatedAt
to determine the date added for documents.Related issues
https://qmacbis.atlassian.net/browse/MR-3578
Screenshots
Test cases covered
UploadedDocumentsTable
has some new tests to reflect the new behavior on review and submit with new submissions (don't show any date/empty string)QA guidance
I ended up separating off the refactor so this change is pretty contained to uploaded documents behavior i would test that across submissions