Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remaining API tests #1955

Closed
wants to merge 5 commits into from
Closed

Enable remaining API tests #1955

wants to merge 5 commits into from

Conversation

macrael
Copy link
Contributor

@macrael macrael commented Oct 5, 2023

Summary

Enabling the tests we had not enabled until all the APIs were converted to the rates refactor.

Related issues

https://qmacbis.atlassian.net/browse/MCR-2370

Copy link
Contributor

@JasonLin0991 JasonLin0991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few test names that need to be updated and merge in main for the Cypress tests.

Co-authored-by: Jason Lin <98117700+JasonLin0991@users.noreply.github.com>
@JasonLin0991
Copy link
Contributor

JasonLin0991 commented Oct 6, 2023

@macrael Cypress is failing the change history test in unlockResubmit. For the PR to turn on the reactor flag in Cypress, I forgot to turn the flag back on for dev when it was running CI 🫠. The PR I have up now fixing the change history got this test to pass.

I'm thinking I should merge that PR into this one?

@JasonLin0991
Copy link
Contributor

JasonLin0991 commented Oct 6, 2023

@macrael Cypress is failing the change history test in unlockResubmit. For the PR to turn on the reactor flag in Cypress, I forgot to turn the flag back on for dev when it was running CI 🫠. The PR I have up now fixing the change history got this test to pass.

I'm thinking I should merge that PR into this one?

We are just going to merge my PR with all this work included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants