[MCR-3547] Add view for adding a mccrs record number #1996
Conversation
services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx
Outdated
Show resolved
Hide resolved
| }, | ||
| }) | ||
|
|
||
| expect(screen.getByTestId('textInput')).toBeInTheDocument() |
There was a problem hiding this comment.
nit: Some of these tests could probably be combined into one. This text input could be moved to 'renders without errors'. And the validation tests could be all in one test.
| } from '../../testHelpers/jestHelpers' | ||
| import { MccrsId } from './MccrsId' | ||
|
|
||
| describe('MCCRSID', () => { |
There was a problem hiding this comment.
nit: A test for failing useUpdateContractMutation would be a good addition. This one might be tricky because you would have to create a new mocked mutation for useUpdateContractMutation that fails. See services/app-web/src/testHelpers/apolloMocks/healthPlanPackageGQLMock.ts for some examples and we could also pair if you need!
…e for inccorect character count
| {showMCCRSRecordNumber && ( | ||
| <Route | ||
| path={RoutesRecord.SUBMISSIONS_MCCRSID} | ||
| element={<MccrsId />} |
There was a problem hiding this comment.
This change caused a flicker of the 404 not found page before going to the MCCRSID page.
Screen.Recording.2023-10-24.at.3.21.17.PM.mov
There was a problem hiding this comment.
Ughhh! And also yes this shouldn't block this PR. To me the flicker is a follow on bug ticket (sure) or just can be wrapped into edit work as we finish out this epic. @pearl-truss happy to take a look at this - lmk
There was a problem hiding this comment.
I think an answer is to only display the blank page until flags have been loaded
There was a problem hiding this comment.
I haven't been able to reproduce this yet. I tried switching the flag on and off and loading the app in an incognito window. If there's anything else I can try, that would be helpful. And I can include a fix for this in the edit ticket.
There was a problem hiding this comment.
I think locally, it happens so fast that you might not see it. If you visit the deployed app for this PR you should be able to see it there
There was a problem hiding this comment.
On local, throttling network speeds might get the bug to show up.
There was a problem hiding this comment.
Got it, thanks Jason :)
| showError={Boolean( | ||
| showFieldErrors(errors.mccrsId) | ||
| )} | ||
| type="text" |
There was a problem hiding this comment.
We should trim the empty spaces before the MC-CRS number, but should we trim spaces in general? For example, 12 34.
This is what the URL looks like with spaces before the ID
There was a problem hiding this comment.
Yes let's trim all whitespace before building those urls, good catch. Since we are following on quickly with edit work I think this doesn't have to block the initial PR.
…e-review into mcr-3547-add-view-mccrs-id
Summary
Adds a form for CMS users to fill out to update the MC-CRS record number which is a field on the contract table
figma designs
Related issues
https://qmacbis.atlassian.net/browse/MCR-3547
To Do items
Screenshots
Test cases covered
QA guidance