-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MCR-3547] Add view for adding a mccrs record number #1996
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
b3c7147
routing for mccrsid field established, bare bones form
pearl-truss 519fe51
Add validation schema
pearl-truss 59237d0
wip calling updateContract api onsubmit
pearl-truss 5e413ca
Merge branch 'main' of https://github.com/Enterprise-CMCS/managed-car…
pearl-truss 028664a
update styling on add mccrs id page
pearl-truss afaccff
finalize styling on the summary page
pearl-truss f6dc708
add unit test for mccrsID form and submission summary pages
pearl-truss 88a4606
additional styling
pearl-truss 52d699d
code cleanup
pearl-truss f3eaa81
Merge branch 'main' of https://github.com/Enterprise-CMCS/managed-car…
pearl-truss 5718bcf
resolving bad merge
pearl-truss 320c017
remove unneeded code in submission summary
pearl-truss cd98ba4
update the custom heading for mccrs page and update validation messag…
pearl-truss 43e4c36
update useEffect code for setting the header
pearl-truss a5087ca
fix existing unit test
pearl-truss 1cb5d8d
PR fixes
pearl-truss 6121942
add link change for mccrs website
pearl-truss 90f7ac0
add feature flag
pearl-truss 0f5fa3d
cypress re-run
pearl-truss 5e563eb
cypress re-run
pearl-truss df44654
remove character limit on mcccrs id field
pearl-truss a44304f
cypress re-run
pearl-truss 31d7bff
trim possible whitespace
pearl-truss efcf16d
Merge branch 'main' of https://github.com/Enterprise-CMCS/managed-car…
pearl-truss df1245a
cypress re-run
pearl-truss a787975
cypress re-run
pearl-truss 6bace5e
rerun all jobs
pearl-truss 099ef61
hide delete button
pearl-truss ba5e2e4
hide delete button
pearl-truss 7130786
remove mccrs-record-number flag, delete button and blank entry valida…
pearl-truss 40b30d6
cypress re-run
pearl-truss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
@import '../../styles/uswdsImports.scss'; | ||
@import '../../styles/custom.scss'; | ||
|
||
.formPage { | ||
width: 100%; | ||
} | ||
|
||
.formContainer.tableContainer { | ||
|
||
&[class^='usa-form'] { | ||
max-width: 100%; | ||
width: 75rem; | ||
} | ||
} | ||
|
||
.formHeader { | ||
text-align: center; | ||
width: 100%; | ||
padding: units(4) 0; | ||
} | ||
|
||
.formContainer { | ||
> [class^='usa-fieldset'] { | ||
padding: units(4); | ||
margin-bottom: units(2); | ||
margin-top: units(2); | ||
background: $cms-color-white; | ||
border: 1px solid $theme-color-base-lighter; | ||
@include u-radius('md'); | ||
} | ||
|
||
h3 { | ||
font-size: 22px; | ||
} | ||
|
||
> div[class^='usa-form-group']:not(:first-of-type) { | ||
margin-top: 2.5rem; | ||
} | ||
|
||
&[class^='usa-form'] { | ||
|
||
min-width: 100%; | ||
max-width: 100%; | ||
|
||
@include at-media(tablet){ | ||
min-width: 40rem; | ||
max-width: 20rem; | ||
margin: 0 auto; | ||
} | ||
} | ||
} | ||
|
||
[class^='usa-legend'] { | ||
margin-top: 0; | ||
} | ||
|
||
div[class^='usa-form-group'] { | ||
margin-top: 24px; | ||
label[class^='usa-label'] { | ||
font-size: 16px; | ||
max-width: 100%; | ||
} | ||
} | ||
|
||
.customHeading { | ||
font-weight: 700; | ||
|
||
span { | ||
font-weight: normal; | ||
margin-left: 16px; | ||
} | ||
} | ||
|
||
div[class^='usa-hint'] span { | ||
span { | ||
display: inline; | ||
font-weight: bold; | ||
} | ||
} | ||
|
||
ul[class^='usa-button-group'] { | ||
justify-content: end; | ||
li[class^='usa-button-group__item'] { | ||
margin-top: 0; | ||
button { | ||
margin-top: 16px; | ||
margin-bottom: 44px; | ||
margin-right: .25rem; | ||
} | ||
} | ||
} | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change caused a flicker of the 404 not found page before going to the MCCRSID page.
Screen.Recording.2023-10-24.at.3.21.17.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a tricky fix. I think it's because we use a hook for feature flags inside the route's component, and that toggles what routes are valid. I wouldn't be opposed to moving this into a separate bug ticket.
Thoughts? @macrael @haworku
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ughhh! And also yes this shouldn't block this PR. To me the flicker is a follow on bug ticket (sure) or just can be wrapped into edit work as we finish out this epic. @pearl-truss happy to take a look at this - lmk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an answer is to only display the blank page until flags have been loaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to reproduce this yet. I tried switching the flag on and off and loading the app in an incognito window. If there's anything else I can try, that would be helpful. And I can include a fix for this in the edit ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think locally, it happens so fast that you might not see it. If you visit the deployed app for this PR you should be able to see it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On local, throttling network speeds might get the bug to show up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks Jason :)