fix: add signSchnorr to keychain api #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboucquez
requested review from
kewde,
diegomura and
mvayngrib
as code owners
fboucquez
added a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 2da2b05)
andrewtoth
reviewed
Nov 14, 2024
| @@ -16,6 +16,7 @@ const createKeychainApi = ({ keychain }) => { | |||
| }, | |||
| secp256k1: { | |||
| signBuffer: keychain.secp256k1.signBuffer, | |||
| signSchnorr: keychain.secp256k1.signSchnorr, | |||
There was a problem hiding this comment.
This should have a type added to index.d.ts as well.
There was a problem hiding this comment.
Sorry, forgot to mention I added in #174.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the keychain's api adding
secp256k1.signSchnorr. If not, signing btc taproot fails with an undefiend error. Thread