Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mujoco v5 environments #85

Merged
merged 39 commits into from
Oct 28, 2024
Merged

Add Mujoco v5 environments #85

merged 39 commits into from
Oct 28, 2024

Conversation

LucasAlegre
Copy link
Member

@LucasAlegre LucasAlegre commented Feb 18, 2024 •
edited
Loading

This PR should be merged when Gymnasium v1.0 is out. It should add:

  • mo-ant-v5
  • mo-halfcheetah-v5
  • mo-hopper-v5
  • mo-swimmer-v5
  • mo-walker2d-v5
  • mo-humanoid-v5

@LucasAlegre LucasAlegre self-assigned this Feb 18, 2024
@LucasAlegre LucasAlegre added the enhancement New feature or request label Feb 18, 2024
@LucasAlegre LucasAlegre marked this pull request as draft February 18, 2024 23:42
@ffelten
Copy link
Collaborator

ffelten commented Feb 19, 2024

No swimmer as in #39 ?

@LucasAlegre
Copy link
Member Author

No swimmer as in #39 ?

True, I forgot about this one.

@ffelten ffelten mentioned this pull request Feb 20, 2024
Open
6 tasks
@LucasAlegre LucasAlegre mentioned this pull request Mar 15, 2024
Merged
Kallinteris-Andreas
Kallinteris-Andreas reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Kallinteris-Andreas Kallinteris-Andreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HalfCheetah LGTM

Hopper needs docstring update

@LucasAlegre LucasAlegre marked this pull request as ready for review October 27, 2024 01:11
@LucasAlegre LucasAlegre requested a review from ffelten October 27, 2024 01:11
ffelten
ffelten requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Also, I think the visuals of the envs changed in v5, might be worth re-generating the gifs for the documentation.

mo_gymnasium/envs/mujoco/__init__.py Show resolved Hide resolved
mo_gymnasium/envs/mujoco/ant_v5.py Outdated Show resolved Hide resolved
mo_gymnasium/envs/mujoco/half_cheetah_v5.py Outdated Show resolved Hide resolved
mo_gymnasium/envs/mujoco/half_cheetah_v5.py Show resolved Hide resolved
@Kallinteris-Andreas
Copy link
Contributor

The Render behavior was not changed from v4 to v5, only new render arguments were added

@ffelten
Copy link
Collaborator

ffelten commented Oct 28, 2024

The Render behavior was not changed from v4 to v5, only new render arguments were added

My bad, I thought they became kinda dark mode like this:
image

Thanks a lot for the support @Kallinteris-Andreas ! Appreciate it :)

@LucasAlegre LucasAlegre merged commit 5b248ed into main Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kallinteris-Andreas Kallinteris-Andreas Kallinteris-Andreas left review comments

@ffelten ffelten ffelten approved these changes

Assignees

@LucasAlegre LucasAlegre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasAlegre @ffelten @Kallinteris-Andreas @pseudo-rnd-thoughts