Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gimbal tf #2

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Publish gimbal tf #2

wants to merge 3 commits into from

Conversation

Flova
Copy link
Owner

@Flova Flova commented Sep 27, 2020

This PR adds the ability to publish multiple ROS TF transforms.
It closes issue #1

@Flova Flova added the enhancement New feature or request label Sep 27, 2020
@Flova
Copy link
Owner Author

Flova commented Sep 27, 2020

This needs some testing on the gimbal setup. It should be ready for merge afterward.
Any feedback @julled ?

@julled
Copy link
Collaborator

julled commented Sep 28, 2020

you added static magic numbers for the transform for a specific gremsy gimbal, which i dont know.
maybe you could make these variables somehow gimbal specific and user accessable via configuration to also use it for various of gremsy gimbals.

@julled
Copy link
Collaborator

julled commented Sep 28, 2020

The given values seem accurate to the centimeter, is this really the case for your particular gimbal?

@Flova
Copy link
Owner Author

Flova commented Sep 28, 2020

This was more or less an estimation using simple physical measurements.
Ideally, these values are loaded from an urdf file by ROS itself for the specific gimbal. Never the less the translations are not that important in most of my use cases.

Maybe I add a small example Gremsy T3V3 urdf in this PR. But not today.

@Flova
Copy link
Owner Author

Flova commented Sep 28, 2020

On the other hand, we could simply use a robot state publisher for this use case. I thought it was overdone at first but now it seems like the right way. We only need to add a joint message publisher inside this node and the rest is done by ROS using the urdf. The robot_state_publisher simply matches the names provided by the joint state message to the joint names in the urdf and adds the dynamic rotations to the specified static transforms.

See: https://wiki.ros.org/robot_state_publisher

@julled
Copy link
Collaborator

julled commented Sep 30, 2020

If it is just too much work, maybe you also point out in the readme.md that the developer needs to change the values for his purpose.

@Flova
Copy link
Owner Author

Flova commented Oct 4, 2020

I removed the static translational transforms from the code and they can be added in an urdf if needed.
I would test and merge this as it is and maybe add a later version using the principle from the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants