Reset xNextTaskUnblockTime in task notify FromISR APIs #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a task is blocked waiting for a notification then xNextTaskUnblockTime might be set to the blocked task's timeout time. If the task is unblocked for a reason other than a timeout xNextTaskUnblockTime is normally left unchanged, because it will automatically get reset to a new value when the tick count equals xNextTaskUnblockTime. However if tickless idle is used it is important to enter sleep mode at the earliest possible time - so reset xNextTaskUnblockTime here to ensure it is updated at the earliest possible time. This was reported here - https://forums.freertos.org/t/the-vtaskgenericnotifygivefromisr-function-need-call-prvresetnexttaskunblocktime/21090 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
aggarg
added a commit
to aggarg/FreeRTOS
that referenced
this pull request
Aug 5, 2024
FreeRTOS/FreeRTOS-Kernel#1111 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
2 tasks
kar-rahul-aws
approved these changes
Aug 5, 2024
|
jefftenney
added a commit
to jefftenney/LPTIM-Tick
that referenced
this pull request
Aug 5, 2024
AniruddhaKanhere
approved these changes
Aug 5, 2024
kar-rahul-aws
pushed a commit
to FreeRTOS/FreeRTOS
that referenced
this pull request
Aug 6, 2024
* Unit test updates for kernel PR #1111 FreeRTOS/FreeRTOS-Kernel#1111 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> * Fix doxygen check Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> --------- Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
moninom1
pushed a commit
to moninom1/FreeRTOS
that referenced
this pull request
Aug 13, 2024
* Unit test updates for kernel PR FreeRTOS#1111 FreeRTOS/FreeRTOS-Kernel#1111 Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> * Fix doxygen check Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> --------- Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a task is blocked waiting for a notification then xNextTaskUnblockTime might be set to the blocked task's timeout time. If the task is unblocked for a reason other than a timeout xNextTaskUnblockTime is normally left unchanged, because it will automatically get reset to a new value when the tick count equals xNextTaskUnblockTime. However if tickless idle is used it is important to enter sleep mode at the earliest possible time - so reset xNextTaskUnblockTime here to ensure it is updated at the earliest possible time.
Test Steps
Tested the change on STM32H7 to ensure that xNextTaskUnblockTime gets reset after the call to vTaskNotifyGiveFromISR.
Checklist:
Related Issue
https://forums.freertos.org/t/the-vtaskgenericnotifygivefromisr-function-need-call-prvresetnexttaskunblocktime/21090
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.