Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob tx support and fuel-vm 0.56.0 #1988

Merged
merged 33 commits into from
Aug 1, 2024
Merged

Blob tx support and fuel-vm 0.56.0 #1988

merged 33 commits into from
Aug 1, 2024

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Jun 26, 2024 •
edited
Loading

Work towards FuelLabs/fuel-specs#589. Spec PR FuelLabs/fuel-specs#592.

Adds support for Blob transactions, which are inserted into the onchain database column called Blobs.
Also updates fuel-vm to 0.56.0, which introduces the new tx type.

Work-in-progress, still needs:

  • Regenesis support
  • Tests

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@Dentosal Dentosal self-assigned this Jun 26, 2024
@Dentosal Dentosal mentioned this pull request Jun 26, 2024
Merged
12 tasks
@Dentosal Dentosal mentioned this pull request Jun 26, 2024
Closed
@arboleya arboleya mentioned this pull request Jul 17, 2024
Closed
8 tasks
@Dentosal Dentosal changed the title Blob tx support Blob tx support and fuel-vm 0.56.0 Jul 29, 2024
@Dentosal Dentosal requested review from Voxelot, a team and segfault-magnet July 29, 2024 14:52
@Dentosal Dentosal added the breaking A breaking api change label Jul 29, 2024
@Dentosal Dentosal marked this pull request as ready for review July 29, 2024 14:53
MitchTurner
MitchTurner reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@MitchTurner MitchTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the one comment.

MitchTurner
MitchTurner reviewed Jul 30, 2024
View reviewed changes
tests/tests/blob.rs
assert!(matches!(status, TransactionStatus::Success { .. }));

// When
let script_tx = TransactionBuilder::script(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using new_blob shouldn't the "when" of this test be sending the Blob tx?

The bsiz is just how you chose to verify that the blob is callable, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and yes. Fixed in a0bdfcc.

xgreenx
xgreenx reviewed Jul 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
bin/fuel-core/chainspec/local-testnet/state_config.json
@@ -119,6 +119,7 @@
}
],
"messages": [],
"blobs": [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't break state config. The blobs should be Option

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blobs is #[serde(default)]. Isn't this enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a local node connected to testnet that serde(default) works 👍🏻

bin/fuel-core/src/cli/snapshot.rs
@@ -801,6 +801,7 @@ mod tests {
StateConfig {
coins: vec![],
messages: vec![],
blobs: vec![],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be None

crates/chain-config/src/config/blob.rs Outdated Show resolved Hide resolved
crates/chain-config/src/config/blob.rs Outdated Show resolved Hide resolved
crates/client/assets/schema.sdl Outdated
@@ -357,7 +359,6 @@ type GasCosts {
divi: U64!
ecr1: U64!
eck1: U64!
ed19: U64!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't remove old ed19. Because of backward compatibility we need to add ed19DependentCost. As we did for aloc opcode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in ebe4c21, let me know if that looks correct.

crates/client/src/client/schema/chain.rs Outdated Show resolved Hide resolved
crates/storage/src/column.rs Outdated Show resolved Hide resolved
@Dentosal Dentosal requested a review from xgreenx July 30, 2024 21:58
@Voxelot Voxelot enabled auto-merge (squash) August 1, 2024 18:25
@Voxelot Voxelot merged commit c2f5a3a into master Aug 1, 2024
32 checks passed
@Voxelot Voxelot deleted the dento/blob-tx branch August 1, 2024 18:44
@danielbate danielbate restored the dento/blob-tx branch August 1, 2024 19:55
@mchristopher mchristopher deleted the dento/blob-tx branch August 1, 2024 20:42
@mchristopher mchristopher restored the dento/blob-tx branch August 1, 2024 20:42
@MitchTurner MitchTurner mentioned this pull request Aug 2, 2024
Merged
MitchTurner added a commit that referenced this pull request Aug 6, 2024
@MitchTurner
Release v0.32.0 (#2053)
ecf5d23 
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
#1983
* Weekly `cargo update` by @github-actions in
#2029
* Add V0 algorithm to actual services by @MitchTurner in
#2025
* Weekly `cargo update` by @github-actions in
#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
#2045
* feat: add chain config to Docker images by @mchristopher in
#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
#2048

## New Contributors
* @mchristopher made their first contribution in
#2052

**Full Changelog**:
v0.31.0...v0.32.0
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this pull request Sep 7, 2024
@GoldenPath1109 @rymnc
Release v0.32.0 (#2053)
a5dd92b 
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
FuelLabs/fuel-core#1983
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2029
* Add V0 algorithm to actual services by @MitchTurner in
FuelLabs/fuel-core#2025
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
FuelLabs/fuel-core#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
FuelLabs/fuel-core#2045
* feat: add chain config to Docker images by @mchristopher in
FuelLabs/fuel-core#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
FuelLabs/fuel-core#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
FuelLabs/fuel-core#2048

## New Contributors
* @mchristopher made their first contribution in
FuelLabs/fuel-core#2052

**Full Changelog**:
FuelLabs/fuel-core@v0.31.0...v0.32.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchTurner MitchTurner MitchTurner left review comments

@Voxelot Voxelot Voxelot approved these changes

@segfault-magnet segfault-magnet segfault-magnet left review comments

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

Assignees

@Dentosal Dentosal

Labels
breaking A breaking api change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dentosal @Voxelot @MitchTurner @xgreenx @segfault-magnet