Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network bytes information for network status gui #419

Merged
merged 40 commits into from
Nov 17, 2023

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Oct 31, 2023

O4B0NMZ 6GBHD YI_IC}(G

@Laiff
Copy link

Laiff commented Oct 31, 2023

Great idea! This can be very useful for most users.
It's good as a starting point, and I think this solution can be improved via separating different types of storages like one group of numbers for items, other one for fluids and one for essences. Also showing all of this numbers on one page will make it unreadable.
It would be better if you separate information on this screen between two tabs that can be switched using button like Energy/Bytes information tabs

@MCTBL
Copy link
Member Author

MCTBL commented Oct 31, 2023

this is only the item cell information, i don't know how to get ae2fc api in ae2...

Copy link

@Laiff Laiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are interested in making it more polished I can provide you with some vision from my side because I also have some thoughts about statistic for AE

src/main/java/appeng/me/cache/GridStorageCache.java Outdated Show resolved Hide resolved
src/main/java/appeng/me/cache/GridStorageCache.java Outdated Show resolved Hide resolved
src/main/java/appeng/me/cache/GridStorageCache.java Outdated Show resolved Hide resolved
src/main/java/appeng/me/cache/GridStorageCache.java Outdated Show resolved Hide resolved
@MadMan310
Copy link

I would suggest adding a way to filter out different types of ME drives. For endgame players with a lot of singularity drives, those drives might give a false representation of the actual storage space of the ME system (although I am not sure if this even accounts for singularity drives at this point)

@MCTBL
Copy link
Member Author

MCTBL commented Nov 1, 2023

I would suggest adding a way to filter out different types of ME drives. For endgame players with a lot of singularity drives, those drives might give a false representation of the actual storage space of the ME system (although I am not sure if this even accounts for singularity drives at this point)

I'm keep trying to do this, but it will take some time..

@MCTBL
Copy link
Member Author

MCTBL commented Nov 2, 2023

image
The fluid byte status is done, then i will try to create a new gui to show all bytes information, unlike now.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 3, 2023

P3YD )53X{F0)9UN8F5)9FS

@miozune
Copy link
Member

miozune commented Nov 3, 2023

I think exposing API for addons to register their own byte information behavior would be better than having everything in base AE2. Especially having circular dependencies is bad in general...

@MCTBL
Copy link
Member Author

MCTBL commented Nov 9, 2023

  1. add recipe in ae2
    image
    It made by Network Tool, ME Conversion Monitor, 64k ME Storage Component and a Capacity Card.
  2. Transparent Facades is working will now
    image
  3. If there are no cell in network, it won't show the NaN % at the end
    image
  4. Still working on it
  5. Now it supports the ME Chest
    image

@Laiff
Copy link

Laiff commented Nov 10, 2023

Also we need to check impact on server load to iterate over two stacks of drives full of big cells. My concern here it can took too much time to recalculate. You can add stopwatch on start of cache update function and log it after it finish, but it should log only if debug logging for timing is enabled. Check AEConfig for details

@Dream-Master
Copy link
Member

@MCTBL can you run spotless?

@MCTBL
Copy link
Member Author

MCTBL commented Nov 12, 2023

@MCTBL can you run spotless?

Sorry about that, I forgot pull before to push it.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 12, 2023

TP9%{$%$)NLA4$P5}2ZS2SW
This is new Gui look like, still designing what should put into lower part.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 12, 2023

}_DUVH}V_B}9E$17(MK7J H
And I'm trying to make the middle part like this.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 14, 2023

U9Q P_UOYG9R6M8P6X`GEU9
VV~)AG6_)41TOL{1CT{$FOH
OP)H%7 Z}9X1I80DK0J@25A

@Dream-Master Dream-Master requested a review from Laiff November 15, 2023 13:03
@Dream-Master
Copy link
Member

Before we merge this it can be tested with this version https://github.com/GTNewHorizons/Applied-Energistics-2-Unofficial/releases/tag/rv3-beta-283-GTNH-pre

@Dream-Master Dream-Master merged commit 0d294c9 into GTNewHorizons:master Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants