-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network bytes information for network status gui #419
Conversation
MCTBL
commented
Oct 31, 2023
Great idea! This can be very useful for most users. |
this is only the item cell information, i don't know how to get ae2fc api in ae2... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are interested in making it more polished I can provide you with some vision from my side because I also have some thoughts about statistic for AE
Co-authored-by: Andrei Antropov <q.laiff@gmail.com>
swap some of Class.forName to instanceof
I would suggest adding a way to filter out different types of ME drives. For endgame players with a lot of singularity drives, those drives might give a false representation of the actual storage space of the ME system (although I am not sure if this even accounts for singularity drives at this point) |
I'm keep trying to do this, but it will take some time.. |
src/main/java/appeng/client/gui/implementations/GuiNetworkStatus.java
Outdated
Show resolved
Hide resolved
I think exposing API for addons to register their own byte information behavior would be better than having everything in base AE2. Especially having circular dependencies is bad in general... |
Also we need to check impact on server load to iterate over two stacks of drives full of big cells. My concern here it can took too much time to recalculate. You can add stopwatch on start of cache update function and log it after it finish, but it should log only if debug logging for timing is enabled. Check AEConfig for details |
Actual function still working on it
Update Settings.java
@MCTBL can you run spotless? |
Sorry about that, I forgot pull before to push it. |
Before we merge this it can be tested with this version https://github.com/GTNewHorizons/Applied-Energistics-2-Unofficial/releases/tag/rv3-beta-283-GTNH-pre |