Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes boilers "getSteamCapacity() aware" #2131

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Makes boilers "getSteamCapacity() aware" #2131

merged 2 commits into from
Jul 11, 2023
+9 −5

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Jul 11, 2023

As discussed with wlhlm/rot13 this converts GT5 to use getSteamCapacity() for boilers. Also makes it easier to control steam capacity if any future subclasses need it.
Needed for: GTNewHorizons/GTplusplus#686

@Lyfts Lyfts mentioned this pull request Jul 11, 2023
Merged
wlhlm
wlhlm requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update in GT_MetaTileEntity_Boiler_Lava#getTankInfo and a rebase. Other than that, tested and working in game. Thanks!

@wlhlm wlhlm changed the title Makes GT5 "getSteamCapacity() aware" Makes boilers "getSteamCapacity() aware" Jul 11, 2023
@Dream-Master Dream-Master merged commit 5113d4b into GTNewHorizons:master Jul 11, 2023
@Lyfts Lyfts deleted the boiler_fix branch August 16, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlhlm wlhlm wlhlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lyfts @wlhlm @Dream-Master