Skip to content
This repository has been archived by the owner on May 26, 2024. It is now read-only.

Advanced boiler steam capacity fix #686

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Jul 9, 2023

Fixes GTNewHorizons/GT-New-Horizons-Modpack#13872

Been broken for 2 years, even if the GTPP method had worked it would spam the vent sound repeatedly as soon as steam filled up.
Tested and works exactly as anticipated. If there is a better method to do this please do let me know.

Should be merged with: GTNewHorizons/GT5-Unofficial#2128

Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Thanks for fixing old bugs 😄

This needs a new GT release and a subsequent update of the dependencies.

@Dream-Master Dream-Master requested a review from wlhlm July 9, 2023 21:41
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in game. An LV Advanced Boiler now correctly vents at 64B instead of 32B. However, the steam fill bar in the GUI still tops out at 32B as reported in the original ticket. Can you look into that as well?

@Lyfts
Copy link
Member Author

Lyfts commented Jul 10, 2023

Of course I forget the gui. Should be an easy fix.

@Lyfts
Copy link
Member Author

Lyfts commented Jul 10, 2023

There might be a better way to do this but it renders correctly now.

@Dream-Master
Copy link
Member

@Lyfts can you run spotless ?

@Lyfts
Copy link
Member Author

Lyfts commented Jul 11, 2023

As discussed this pr makes GT5 understand getSteamCapacity() which also obsoletes most of the previous fixes to the GT++ boilers.
Both GT5 and GT++ boilers are tested and working.

Lyfts and others added 2 commits July 11, 2023 18:56
Been broken for 2 years now it works as anticipated.
@wlhlm wlhlm changed the title Advanced boiler fix Advanced boiler steam capacity fix Jul 11, 2023
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Dream-Master Dream-Master merged commit 395eec3 into GTNewHorizons:master Jul 11, 2023
1 check passed
@Lyfts Lyfts deleted the boiler_fix branch September 1, 2023 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singleblock Advanced Boiler [LV] - Incorrect Maximum steam storage - Waila Tooltip
3 participants