docs: update custom timeout and retry sample #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a couple of minor issues in the retry- and timeout sample: 1. Remove DeadlineExceeded as a retryable code, as the sample uses a single timeout and will not retry on DeadlineExceeded anyways, meaning that the addition of that error code was just confusing. 1. Update the maxBackoff to 16 seconds. We are setting this value to 16 seconds for all client libraries, as it makes the sample confusing when the max backoff is larger than the total timeout (60 seconds). The documentation page that uses this sample is https://cloud.google.com/spanner/docs/custom-timeout-and-retry Do not merge: Please hold off on merging until all the samples have been updated.
olavloite
added
the
do not merge
product-auto-label
bot
added
the
samples
shivgautam
approved these changes
Sep 25, 2023
olavloite
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of minor issues in the retry- and timeout sample:
The documentation page that uses this sample is https://cloud.google.com/spanner/docs/custom-timeout-and-retry
Do not merge: Please hold off on merging until all the samples have been updated.