Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update custom timeout and retry sample #1174

Merged
merged 1 commit into from
Sep 28, 2023
Merged

docs: update custom timeout and retry sample #1174

merged 1 commit into from
Sep 28, 2023

Commits on Sep 21, 2023

  1. docs: update custom timeout and retry sample 

    Fixes a couple of minor issues in the retry- and timeout sample:

1. Remove DeadlineExceeded as a retryable code, as the sample uses a single timeout and will not retry on DeadlineExceeded anyways, meaning that the addition of that error code was just confusing.
1. Update the maxBackoff to 16 seconds. We are setting this value to 16 seconds for all client libraries, as it makes the sample confusing when the max backoff is larger than the total timeout (60 seconds).

The documentation page that uses this sample is https://cloud.google.com/spanner/docs/custom-timeout-and-retry

Do not merge: Please hold off on merging until all the samples have been updated.
    @olavloite
    olavloite authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    49288de View commit details
    Browse the repository at this point in the history