Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove catalog prefix #3835

Merged
merged 5 commits into from
Apr 30, 2024
Merged

refactor: remove catalog prefix #3835

merged 5 commits into from
Apr 30, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 29, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Wait for #3833

Remove the catalog prefix

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners April 29, 2024 06:59
@WenyXu WenyXu marked this pull request as draft April 29, 2024 06:59
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 29, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.27%. Comparing base (701aba9) to head (da77bd4).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3835      +/-   ##
==========================================
- Coverage   85.64%   85.27%   -0.37%     
==========================================
  Files         954      953       -1     
  Lines      163037   162935     -102     
==========================================
- Hits       139625   138946     -679     
- Misses      23412    23989     +577

@WenyXu WenyXu force-pushed the refactor/remove-catalog-prefix branch from 47c5974 to 3b10465 Compare April 29, 2024 07:58
@WenyXu WenyXu mentioned this pull request Apr 29, 2024
Merged
3 tasks
@WenyXu WenyXu force-pushed the refactor/remove-catalog-prefix branch from cfdeb47 to 640df91 Compare April 29, 2024 14:36
@WenyXu WenyXu marked this pull request as ready for review April 29, 2024 14:36
@WenyXu WenyXu force-pushed the refactor/remove-catalog-prefix branch 2 times, most recently from 374ff44 to 6bae11a Compare April 29, 2024 14:42
evenyag
evenyag approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fengjiachun
fengjiachun approved these changes Apr 30, 2024
View reviewed changes
src/common/meta/src/key/flow/flow_name.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow/table_flow.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu enabled auto-merge April 30, 2024 03:15
@WenyXu WenyXu added this pull request to the merge queue Apr 30, 2024
Merged via the queue into GreptimeTeam:main with commit 20cbc03 Apr 30, 2024
22 checks passed
@WenyXu WenyXu deleted the refactor/remove-catalog-prefix branch April 30, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WenyXu @MichaelScofield @fengjiachun @evenyag