fix: deprecation of Theme._vars by using config attributes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 81.94% 81.92% -0.03%
==========================================
Files 9 9
Lines 432 437 +5
Branches 96 97 +1
==========================================
+ Hits 354 358 +4
Misses 51 51
- Partials 27 28 +1
|
|
Thanks for picking this (#206) up! |
|
I've asked on Material discussion: squidfunk/mkdocs-material#6453 |
Guts
force-pushed
the
fix/205-replace-theme_vars-with-attributes
branch
from
2c0d9d9 to
d0903cf
Compare
YDX-2147483647
added a commit
to YDX-2147483647/mkdocs-rss-plugin
that referenced
this pull request
Mar 5, 2024
`locale` at root was deprected in Guts#212, and `theme/language` only works for Material theme. Relevant implementation: https://github.com/Guts/mkdocs-rss-plugin/blob/15938261138769919c714e60d4925c58bffa81e1/mkdocs_rss_plugin/util.py#L720-L723 Signed-off-by: Y.D.X. <73375426+YDX-2147483647@users.noreply.github.com>
YDX-2147483647
added a commit
to YDX-2147483647/mkdocs-rss-plugin
that referenced
this pull request
Mar 5, 2024
`locale` at root was deprecated in Guts#212, and `theme/language` only works for Material theme. Relevant implementation: https://github.com/Guts/mkdocs-rss-plugin/blob/15938261138769919c714e60d4925c58bffa81e1/mkdocs_rss_plugin/util.py#L720-L723 Signed-off-by: Y.D.X. <73375426+YDX-2147483647@users.noreply.github.com>
Guts
added a commit
that referenced
this pull request
Mar 5, 2024
`locale` at root was deprecated in #212, and `theme/language` only works for Material theme. Relevant implementation: https://github.com/Guts/mkdocs-rss-plugin/blob/15938261138769919c714e60d4925c58bffa81e1/mkdocs_rss_plugin/util.py#L720-L723
YDX-2147483647
added a commit
to YDX-2147483647/summaries
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #206
Closes #205