Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorilla-cli: disable #188498

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Formula/g/gorilla-cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ class GorillaCli < Formula
sha256 cellar: :any_skip_relocation, x86_64_linux: "c3909a9070a0bc65842f887b937bb8f8613b5c40e4e4de86e8cd1ef4e82a41c2"
end

# upstream bug report, https://github.com/gorilla-llm/gorilla-cli/issues/64
disable! date: "2024-09-12", because: "cli does not work due to `LoadingServer is unreachable`"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling for not responding to an issue after three weeks seems a bit much.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, just throw here for discussion.

the formula is not working atm at all. (I was thinking to deprecate in the first place)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short of disabling the formula, the test could be weakened to only check whether the command runs, even when the API is down.


depends_on "certifi"
depends_on "python@3.12"

Expand Down
Loading