gorilla-cli: disable #188498
Draft
gorilla-cli: disable #188498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
chenrui333
added
the
CI-syntax-only
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
gorilla-cli-deprecate
branch
from
1e4a0c8
to
ac7db2a
Compare
github-actions
bot
added
formula disabled
carlocab
reviewed
Sep 13, 2024
| @@ -18,6 +18,9 @@ class GorillaCli < Formula | |||
| sha256 cellar: :any_skip_relocation, x86_64_linux: "c3909a9070a0bc65842f887b937bb8f8613b5c40e4e4de86e8cd1ef4e82a41c2" | |||
| end | |||
|
|
|||
| # upstream bug report, https://github.com/gorilla-llm/gorilla-cli/issues/64 | |||
| disable! date: "2024-09-12", because: "cli does not work due to `LoadingServer is unreachable`" | |||
There was a problem hiding this comment.
Disabling for not responding to an issue after three weeks seems a bit much.
There was a problem hiding this comment.
yeah, just throw here for discussion.
the formula is not working atm at all. (I was thinking to deprecate in the first place)
There was a problem hiding this comment.
Short of disabling the formula, the test could be weakened to only check whether the command runs, even when the API is down.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?put as draft for a couple of days and see if upstream can fix the issue, currently the cli is not working.