Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strongly typed Datastore configuration - Fixes #2088 #2223

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Strongly typed Datastore configuration - Fixes #2088 #2223

wants to merge 1 commit into from

Conversation

johnaohara
Copy link
Member

This is a fairly major re-factor of the Datastore configuration API.

It solves the following problems;

  • Add Strongly Typed authentication models: No Auth, Api Key and Username/Password
  • Add openapi discriminators for datastore authentication types
  • Fixes validation for all datastores: Fixes Elasticsearch configuration always requires credentials #2088
  • UI dynamically displays auth properties based on available auth types and user selected auth type
  • Add validation of authentication when updated existing datastores

@johnaohara johnaohara changed the title Issue 2088 Strongly typed Datastore configuration - Fixes #2088 Dec 24, 2024
@johnaohara johnaohara marked this pull request as ready for review December 24, 2024 09:20
@johnaohara johnaohara marked this pull request as draft December 24, 2024 09:21
@johnaohara johnaohara mentioned this pull request Dec 24, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch configuration always requires credentials
1 participant
@johnaohara