Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frequent crashes of figure8 example #391

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix frequent crashes of figure8 example #391

merged 1 commit into from
Dec 21, 2023

Conversation

whoenig
Copy link

@whoenig whoenig commented Dec 20, 2023

  • Update crazyflie_cpp to upload trajectory pieces one-by-one (waiting for the result), similar to how we handle firmware communication issues for reading the various TOCs or parameters
  • Changing the Python layer to make uploadTrajectory a blocking call, i.e., waiting until the upload succeeded

Fixes #390

@whoenig
Fix frequent crashes of figure8 example
e954bc8 
* Update crazyflie_cpp to upload trajectory pieces one-by-one (waiting for the result), similar to how we handle firmware communication issues for reading the various TOCs or parameters
* Changing the Python layer to make uploadTrajectory a blocking call, i.e., waiting until the upload succeeded
knmcguire
knmcguire approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I'll merge

@knmcguire knmcguire merged commit 8ba970f into main Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knmcguire knmcguire knmcguire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure8 example results in frequent crashes in system tests
2 participants
@whoenig @knmcguire