Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robot_description support [cpp,cflib,sim] #412

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Add robot_description support [cpp,cflib,sim] #412

merged 5 commits into from
Jan 31, 2024

Conversation

whoenig
Copy link

@whoenig whoenig commented Jan 30, 2024

No description provided.

@whoenig whoenig changed the title update URDF Add robot_description support [cpp,cflib,sim] Jan 30, 2024
knmcguire
knmcguire approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe in the future we can add disks to the model as it looks a bit weird with the props not moving when it's in the air ;) but that is purely esthetics.

@whoenig whoenig merged commit f861618 into main Jan 31, 2024
3 checks passed
@whoenig whoenig deleted the feature_robot_desc branch January 31, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knmcguire knmcguire knmcguire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whoenig @knmcguire