Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate automatic download of SD data in test_flights.py #477

Merged
merged 22 commits into from
Apr 25, 2024

Conversation

julienthevenoz
Copy link

@julienthevenoz julienthevenoz commented Apr 11, 2024

-added 5 files from Denis' plotting code (all in the SDplotting subfolder of systemtests)
-added commands to enable/disable logging in the two example scripts (figure8 and multi_trajectory)

  • modified test_flights.py to automatically download the SD data and plot it (using Denis' code)

I still have some recurring (and seemingly unrelated ?) bugs, documented in the "bugs" folder, which very often make the tests fail and prevent me from being 100% sure that this code works smoothly.

  • Fixed crashing when trying to set a parameter that doesn't exist.
    Detail : if (crazyflie.py)setParam was called with a param that doesn't exist, keyError was raised which would crash crazyflie_server. For example in simulation there are no params initialized at all, so trying to set any of them would always crash. Solved this with a try-catch block which indicates logs an error but doesn't crash crazyflie_server

Copy link

@whoenig whoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks - just one small change needed.

crazyflie/config/crazyflies.yaml Outdated Show resolved Hide resolved
@julienthevenoz julienthevenoz merged commit d9064d9 into main Apr 25, 2024
3 of 4 checks passed
@julienthevenoz julienthevenoz deleted the feature_download_uSD_test_flights branch May 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants