forked from USC-ACTLab/crazyswarm
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate automatic download of SD data in test_flights.py #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntal because CF never flies
whoenig
requested changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks - just one small change needed.
whoenig
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-added 5 files from Denis' plotting code (all in the SDplotting subfolder of systemtests)
-added commands to enable/disable logging in the two example scripts (figure8 and multi_trajectory)
I still have some recurring (and seemingly unrelated ?) bugs, documented in the "bugs" folder, which very often make the tests fail and prevent me from being 100% sure that this code works smoothly.
Detail : if (crazyflie.py)setParam was called with a param that doesn't exist, keyError was raised which would crash crazyflie_server. For example in simulation there are no params initialized at all, so trying to set any of them would always crash. Solved this with a try-catch block which indicates logs an error but doesn't crash crazyflie_server