Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tmp yaml files generated for server and motion capture. Add motion capture yaml import feature. #538

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

llanesc
Copy link

@llanesc llanesc commented Jun 28, 2024

Fix for #536. Most of the changes are switching from " to ' to be more consistent. To remove the temp files we can just pass the parameters directly from line 62-63.

@llanesc
Copy link
Author

llanesc commented Jun 28, 2024

I haven't tested the motion capture yaml file import feature, but it's imported the same as the crazyflies.yaml.

@llanesc llanesc changed the title remove tmp yaml files generated for server and motion capture remove tmp yaml files generated for server and motion capture. Add motion capture yaml import feature. Jun 28, 2024
@knmcguire
Copy link
Collaborator

Thanks for this! We are just a bit occupied with some deadlines/holidays/workshop organizing. Once I'm back the 23rd I'll merge this along with a sync update to our stab lab (or else my colleagues won't be happy with me 😄 )

@llanesc
Copy link
Author

llanesc commented Jul 7, 2024

No worries at all.

@knmcguire knmcguire linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it out, no more tmp files! thanks!

I'll merge it :D

@knmcguire knmcguire merged commit ae8fb49 into IMRCLab:main Jul 23, 2024
4 checks passed
@llanesc llanesc deleted the pr-remove-tmp-yaml branch July 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tmp yaml file generation
2 participants