Misc fixups #1
Open
Misc fixups #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The least significant bit on cmd1 is a continuation flag, on some USB devices some upload commands can be chunked and this flag indicates whether the packet is a continuation of a previous message.
Enable the dissectors on some known USB devices, and allow to manually add the v2 encapsulation dissector to USB devices as well.
Just change the order of some lines to make future changes more readable.
…ackets Skip parsing body for continuation packets for now, as they have a different structure, maybe the cmd name parsing could be added back, but it seemed more work that it was worth. Also fix the checksum position for normal packets, in USB communication the body can be smaller than the packet size, so the checksum is not always the last byte of the packet.
The 0xd2 message is used on some USB devices, supposedly for a TLS-like handshake, only add some placeholders also for replies as there are replies to this message.
The 0xE and 0xF packet descriptions ended up in the wrong dictionary level and were not processed as expected, restore them and add some tentative info for the 0xE2 message.
|
@JJJollyjim ping. Would it make sense to have these changes merged? Thanks, Antonio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some misc fixes for USB devices.
Ciao, Antonio