Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixups #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Misc fixups #1

wants to merge 7 commits into from

Commits on Oct 25, 2020

  1. Improve documentation of the least significant bit of cmd1 

    The least significant bit on cmd1 is a continuation flag, on some USB
devices some upload commands can be chunked and this flag indicates
whether the packet is a continuation of a previous message.
    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    6dfd3fe View commit details
    Browse the repository at this point in the history

  2. Enable the dissectors on some known USB devices 

    Enable the dissectors on some known USB devices, and allow to manually
add the v2 encapsulation dissector to USB devices as well.
    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    26c20a4 View commit details
    Browse the repository at this point in the history

  3. Fix some typos

    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    0859320 View commit details
    Browse the repository at this point in the history

  4. Reorder some code in preparation for future changes 

    Just change the order of some lines to make future changes more
readable.
    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    56e73f1 View commit details
    Browse the repository at this point in the history

  5. Skip parsing body for continuation packets, fix checksum for normal p… 

    …ackets

Skip parsing body for continuation packets for now, as they have
a different structure, maybe the cmd name parsing could be added back,
but it seemed more work that it was worth.

Also fix the checksum position for normal packets, in USB communication
the body can be smaller than the packet size, so the checksum is not
always the last byte of the packet.
    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    6d4c1e6 View commit details
    Browse the repository at this point in the history

  6. Improve the description of 0xd2 message used on some USB devices 

    The 0xd2 message is used on some USB devices, supposedly for a TLS-like
handshake, only add some placeholders also for replies as there are
replies to this message.
    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    ddd3b32 View commit details
    Browse the repository at this point in the history

  7. Fix parsing of 0xE and 0xF commands, and add tentative 0xE2 name 

    The 0xE and 0xF packet descriptions ended up in the wrong dictionary
level and were not processed as expected, restore them and add some
tentative info for the 0xE2 message.
    @ao2
    ao2 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    b54c87d View commit details
    Browse the repository at this point in the history