-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator dashboard QA #4743
Comments
DashboardTested on https://dao-git-validators-joystream.vercel.app/ Mainnet ✅ Dashboard statistic headers statistic accuracy
|
@kdembler @ivanturlakov |
@ivanturlakov |
Retested on https://dao-9pwmfuy5v-joystream.vercel.app/ mainnet ✅ tooltips @eshark9312 thanks! Pls add a minor fix for Social links @kdembler what do you think about the formula for calculating expected Nominator APR? I am a Nominator and have checked my actual average APR and it ranges from 5 to 7% while the expected APR shows 1% |
@ivanturlakov thank you for the quick feedback. But the correct environment is: https://dao-git-fork-eshark9312-validator-dashboard-qa-joystream.vercel.app/ (not https://dao-9pwmfuy5v-joystream.vercel.app). On the APR thanks a lot for checking, it's very important to make sure we are not underestimating those. I'll look some more into it this week. @kdembler @eshark9312 please have look too. |
@ivanturlakov |
@ivanturlakov
I fixed it, in this case the save button should be disabled until click the add button. |
This is not obvious logic. Validator address fields should work like a normal form field - if there is an address there, then it is valid. The add button should only be responsible for adding a new validator address field. If we leave everything as it is, we need to add an explanation (after entering the validator, press the plus button). @kdembler @thesan what you think? |
The QA should start only once #4742 and Joystream/joystream#4933 get merged and
dev
is merged into validator branch one last time.Context
Designs
Testing environment 👉 https://dao-git-validators-joystream.vercel.app
Scope
Dashboard itself
This should be tested at least partially on Mainnet. There has been some back and forth on how to calculate some of the values and it's important to make sure that non what is displayed is misleading to nominators. Also this page should work well in mobile:
Binding validator accounts to memberships
It might be easier to test this on a playground. In that case Atlas dev should be fine: https://dao-git-validators-joystream.vercel.app/#/settings?network-config=https://atlas-dev.joystream.org/network/config.json
Regardless you'll need to create validator accounts on the network used for the tests.
verifyValidator
joystream#4933) and check their statuses on the dashboard.The text was updated successfully, but these errors were encountered: