feat: use a driver script for codefile appbundles #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
changed the title
pfitzseb
reviewed
May 28, 2024
|
Dear colleagues, would it be possible to return the |
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
…/JuliaHub.jl into mp/appbundle-clarify-docs
pfitzseb
previously approved these changes
May 31, 2024
pfitzseb
force-pushed
the
mp/appbundle-clarify-docs
branch
from
29cc716
to
5f32818
Compare
pfitzseb
force-pushed
the
mp/appbundle-clarify-docs
branch
from
5f32818
to
877b6f0
Compare
pfitzseb
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you submit an appbundle where you specify the code via a path, i.e.
JuliaHub.appbundle(dir, file), it now launches it with the help of a driver script. This ensures that@__DIR__etc. are set up correctly andincludeworks as the user would expect.Fix #37.