Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tridiagonal construction rule #758

Merged
merged 10 commits into from
Jun 10, 2024
Merged

Add Tridiagonal construction rule #758

merged 10 commits into from
Jun 10, 2024

Conversation

ChrisRackauckas
Copy link
Member

@ChrisRackauckas ChrisRackauckas commented Nov 22, 2023

ChrisRackauckas and others added 2 commits November 22, 2023 10:48
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ChrisRackauckas
Copy link
Member Author

@avik-pal

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/rulesets/LinearAlgebra/structured.jl Outdated Show resolved Hide resolved
src/rulesets/LinearAlgebra/structured.jl Outdated Show resolved Hide resolved
Co-authored-by: Frames White <oxinabox@ucc.asn.au>
@oxinabox
Copy link
Member

oxinabox commented Nov 23, 2023

If tests pass (I know one of our CIs is broken for unzip) merge and tag (minor)!when happy.

test/rulesets/LinearAlgebra/structured.jl Outdated Show resolved Hide resolved
ChrisRackauckas and others added 2 commits November 23, 2023 09:34
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Frames White <oxinabox@ucc.asn.au>
@mcabbott
Copy link
Member

Is there a minimal example of what problem this solves?

There is some chance that it would be fixed by JuliaDiff/ChainRulesCore.jl#446 , which is really part of the original idea of ProjectTo.

@ChrisRackauckas
Copy link
Member Author

@oxinabox
Copy link
Member

Once JuliaDiff/FiniteDifferences.jl#237
is merged this will pass tests.

@oxinabox oxinabox closed this May 31, 2024
@oxinabox oxinabox reopened this May 31, 2024
@avik-pal
Copy link

avik-pal commented Jun 9, 2024

What is the current status for this?

@oxinabox oxinabox merged commit 78f00cb into main Jun 10, 2024
11 of 22 checks passed
@oxinabox oxinabox deleted the ChrisRackauckas-patch-1 branch June 10, 2024 08:49
@oxinabox
Copy link
Member

Merged.
It was just blocked waiting for me to come back and see it passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move AD Rules to SciMLSensitivity
4 participants