Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tridiagonal in to_vec #237

Merged
merged 1 commit into from
May 31, 2024
Merged

Support Tridiagonal in to_vec #237

merged 1 commit into from
May 31, 2024

Conversation

oxinabox
Copy link
Member

Encountered in JuliaDiff/ChainRules.jl#758
Problem was there is a du2 field which isn't used except as an implementation detail of lu.
It is the value on the diag(x, 2)but its not used by==` etc because it's not part of the actual tridiagonal.

Reading this was causing errors with reading undefined values.

@oxinabox oxinabox requested a review from willtebbutt May 20, 2024 13:40
@oxinabox oxinabox merged commit 148c564 into main May 31, 2024
16 of 18 checks passed
@oxinabox oxinabox deleted the ox/triangle branch May 31, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant