Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ImageBinarization to Images.jl #1030

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Adds ImageBinarization to Images.jl #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e77a219
Adds ImageBinarization to Images.jl
ashwani-rathee Jul 14, 2023
43ef624
Update UnitTest.yml
ashwani-rathee Jul 15, 2023
2dfb0b6
Update Project.toml
ashwani-rathee Jul 19, 2023
23b321e
Merge branch 'master' into ash/binarize
timholy Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/UnitTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
julia-version: ['1.3', '1', 'nightly']
julia-version: ['1.6', '1', 'nightly']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we drop the CI for Julia < 1.6, then it's better to change julia = "1.3" in the [compat] section in Project.toml as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍🏻 ,Is it alright that I am changing version to 0.26.0, assuming it's kind of breaking?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, it might be a good idea to merge #1011 and perhaps #1027 for 0.26

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I merge this first and then see what could be done about #1011 and #1027? After all that is done, then release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I again don't have merge rights here and for good reasons 🤣

os: [ubuntu-latest]
arch: [x64]
include:
Expand Down
6 changes: 4 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
name = "Images"
uuid = "916415d5-f1e6-5110-898d-aaa5f9f070e0"
version = "0.25.3"
version = "0.26.0"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
Graphics = "a2bd30eb-e257-5431-a919-1863eab51364"
ImageAxes = "2803e5a7-5153-5ecf-9a86-9b4c37f5f5ac"
ImageBase = "c817782e-172a-44cc-b673-b171935fbb9e"
ImageBinarization = "cbc4b850-ae4b-5111-9e64-df94c024a13d"
ImageContrastAdjustment = "f332f351-ec65-5f6a-b3d1-319c6670881a"
ImageCore = "a09fc81d-aa75-5fe9-8630-4744c3626534"
ImageDistances = "51556ac3-7006-55f5-8cb3-34580c88182d"
Expand Down Expand Up @@ -35,6 +36,7 @@ FileIO = "1"
Graphics = "0.4, 1.0"
ImageAxes = "0.6.9"
ImageBase = "0.1.5"
ImageBinarization = "^0.2"
ImageContrastAdjustment = "0.3.3"
ImageCore = "0.9.3"
ImageDistances = "0.2.5"
Expand All @@ -54,7 +56,7 @@ StaticArrays = "0.8, 0.9, 0.10, 0.11, 0.12, 1.0"
StatsBase = "0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33, 0.34"
Suppressor = "0.2"
TiledIteration = "0.2, 0.3, 0.4"
julia = "1.3"
julia = "1.6"

[extras]
FFTW = "7a1cc6ca-52ef-59f5-83cd-3a7055c09341"
Expand Down
1 change: 1 addition & 0 deletions src/Images.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ using IndirectArrays, ImageCore.MappedArrays

const is_little_endian = ENDIAN_BOM == 0x04030201 # CHECKME(johnnychen94): is this still used?

@reexport using ImageBinarization
@reexport using ImageTransformations
@reexport using ImageAxes
@reexport using ImageMetadata
Expand Down
Loading