Adds ImageBinarization to Images.jl #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ashwani-rathee
commented
Jul 14, 2023
ashwani-rathee
commented
- Adds ImageBinarization to Images.jl
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 8 8
Lines 823 823
=======================================
Hits 721 721
Misses 102 102
☔ View full report in Codecov by Sentry. |
johnnychen94
previously approved these changes
Jul 19, 2023
| @@ -14,7 +14,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| julia-version: ['1.3', '1', 'nightly'] | |||
| julia-version: ['1.6', '1', 'nightly'] | |||
There was a problem hiding this comment.
If we drop the CI for Julia < 1.6, then it's better to change julia = "1.3" in the [compat] section in Project.toml as well
There was a problem hiding this comment.
Okay 👍🏻 ,Is it alright that I am changing version to 0.26.0, assuming it's kind of breaking?
There was a problem hiding this comment.
Also I again don't have merge rights here and for good reasons 🤣
|
I'm okay to have ImageBinarization in Images, but since I'm not working actively here, it's better for others to merge. |
1 task
This was referenced Jul 23, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.