Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] reexport ImageBinarization and HistogramThresholding #905

Closed
wants to merge 1 commit into from

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Jul 22, 2020

We need to review and update both packages before we reexport them here

TODO: (there will be more as we proceeding this)

The compilation time contributed by them doesn't look good right now

# Version 1.6.0-DEV.497 (2020-07-20)

# before
julia> @time using Images
  3.687936 seconds (9.14 M allocations: 584.557 MiB, 4.90% gc time)

# after
julia> @time using Images
  4.420445 seconds (11.35 M allocations: 714.150 MiB, 4.69% gc time)

cc: @zygmuntszpak

@johnnychen94 johnnychen94 added this to the v1.0 milestone Jul 22, 2020
@johnnychen94 johnnychen94 added the enhancement Adds a new feature. label Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #905 into master will increase coverage by 7.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   77.30%   84.63%   +7.33%     
==========================================
  Files           8        9       +1     
  Lines         661      944     +283     
==========================================
+ Hits          511      799     +288     
+ Misses        150      145       -5     
Impacted Files Coverage Δ
src/Images.jl 25.00% <ø> (+25.00%) ⬆️
src/compat.jl 50.00% <0.00%> (ø)
src/deprecations.jl 85.32% <0.00%> (+2.56%) ⬆️
src/algorithms.jl 85.04% <0.00%> (+6.88%) ⬆️
src/corner.jl 84.29% <0.00%> (+9.29%) ⬆️
src/edge.jl 82.48% <0.00%> (+15.11%) ⬆️
src/labeledarrays.jl 100.00% <0.00%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8643e7c...ff380f0. Read the comment docs.

@timholy
Copy link
Member

timholy commented Jul 23, 2023

Closed by #1030

@timholy timholy closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants