Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Add nullbitsco tidbit board with pin mapping; doc updates; hex composer #915

Closed
wants to merge 1 commit into from

Conversation

patricksurry
Copy link
Contributor

The hex_compose module is experimental keyboard-side composer for ascii/unicode characters which i'll use to drive a retro pc. I can separate into a different PR if that's helpful

Copy link

@jaygreco jaygreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There is only one change (keycode syntax) I needed to make to run this on my development TIDBIT with Bit-C PRO.


keyboard.keymap = [
[
XXXXX, KC.PSLS, KC_PAST, KC_PMNS,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will all need to be converted from QMK syntax (underscore) to KMK (dot):

keyboard.keymap = [
    [
        XXXXX,  KC.PSLS, KC.PAST, KC.PMNS,
        KC.P7,  KC.P8,   KC.P9,   KC.PPLS,
        KC.P4,  KC.P5,   KC.P6,   KC.PPLS,
        KC.P1,  KC.P2,   KC.P3,   KC.PENT,
        KC.P0,  KC.P0,   KC.PDOT, KC.PENT,
    ]
]

@patricksurry patricksurry changed the title Add nullbitsco tidbit board with pin mapping; doc updates; hex composer [do not merge] Add nullbitsco tidbit board with pin mapping; doc updates; hex composer Dec 4, 2023
@patricksurry
Copy link
Contributor Author

patricksurry commented Dec 4, 2023

Splitting this into smaller PRs.

@patricksurry patricksurry mentioned this pull request Dec 4, 2023
@xs5871
Copy link
Collaborator

xs5871 commented Dec 5, 2023

There are significant overlaps between #916 and #918. What do you want me to do here? Would you like to split those into atomic, potentially dependent PRs? Also, please close PRs you don't want to be considered for merging.

@patricksurry
Copy link
Contributor Author

Sorry, yes I will close this PR. Please go ahead and merge 916 (if it looks ok) and I'll rebase 918 and resubmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants